-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing tests for auto-binded class methods defined via arrow functions. #8
Conversation
👍 These are currently really problematic (I don't know how to handle them). |
By the way (don't mean to be pedantic) this is class property syntax proposed for ES7. |
I know. But it compiles with --stage 0, so it is good enough for me;) On Saturday, August 22, 2015, Dan Abramov notifications@github.com wrote:
|
I ran into this as well and was going to make a PR with failing tests but you did the work for me. Thanks! Hope something can be figured out for these since they're so darn useful with React. |
I want to avoid spending significant effort here until we're at least sure this is the way properties will end up. So far the news aren't very encouraging: https://twitter.com/sebmarkbage/status/646473000749928448 |
Might it be time to revisit this now that the proposal is at stage 2 and new react docs refer to this feature (albeit with an experimental feature caveat)? |
+1 - is this something we can start looking into? |
I guess this PR is not valid for v3-alpha, am I right @nikolaymatrosov ? |
Proposal is now stage 3. |
Any news on supporting this now that it's at stage 3? |
@gaearon Hi, I've read your thoughts on this feature from 2015/2016. Now it's in a good way of being part of one of the norm. Do you think the effort worth the benefits ? |
I scetched some tests that follow pattern that I use to define auto-binded method in ES6 classes. I tried to highlight the problem I have encountered using previous version of React Hot Loader. The tests could be wrong, I just wanted to add some illustration to my feature request. It would be awesome if the new version of Hot Reloader could handle this case.